In optimizeComponents be sure to also remove components that are defined in the primitive with empty object #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned in the primitive with empty object
|
@dmarcos that's a small part of my work on a better full html export of a-scene I'm currently doing. |
|
in controllers.html with the mixin <a-mixin id="interactable" event-set__mouseenter="_event: mouseenter; material.opacity: 0.75" event-set__mouseleave="_event: mouseleave; material.opacity: 1" event-set__click="_event: click; scale: 1.1 1.1 1.1"></a-mixin>The entity <a-entity id="redBox" mixin="interactable" geometry="primitive: box" material="color: #F00" position="-4 1 0">was exported to html with <a-entity id="redBox" mixin="interactable" geometry="primitive: box" material="color: #F00" position="-4 1 0" event-set__mouseenter="[object Object]" event-set__mouseleave="[object Object]" event-set__click="[object Object]">
The serialization to |
…vent-set__click when checking for implicit value (from mixin or primitive)
vincentfretin
force-pushed
the
fix-optimize-components
branch
from
cdc1a89 to
2d1358b
Compare
|
For the |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In optimizeComponents used by the copy entity to clipboard feature, be sure to also remove components that are defined in the primitive with empty object, for example a-camera here https://github.com/aframevr/aframe/blob/a26768db5fe0f04a3b8fec3e73780b1855c3c75c/src/extras/primitives/primitives/a-camera.js#L5-L7
defaultComponentsFromPrimitiveis defined bythis.defaultComponentsFromPrimitive = definition.defaultComponents || definition.defaultAttributes || {};in aframe registerPrimitive. https://github.com/aframevr/aframe/blob/a26768db5fe0f04a3b8fec3e73780b1855c3c75c/src/extras/primitives/primitives.js#L37defaultComponentsis only on the definition, never on the html element, so checking forsource.defaultComponentsis always undefined from my understanding.I modified
getInjectedValueto check onlydefaultComponentsFromPrimitiveand don't create unnessary object if it's undefined.Also in
getMixedValue, the linesource.mixinEls.reverse()was reversing the mixinEls in place, so the order changed on each execution, not really what we want here, I replaced bytoReversed()getImplicitValuedidn't return isInherited true in case of empty object in the primitivedefaultComponents, so the component wasn't deleted as part of theif (isInherited && doesNotNeedUpdate)check.aframe-inspector/src/lib/entity.js
Lines 201 to 202 in ebb07fa
I fixed it.
Before:
After:
raycasteris set by thecursorcomponent so that's why it still shows up, but I don't mind, it's good practice to define objects property inraycasteranyway.Before:
After: